Modified the set_node_bubble_effect_property() function so it will on…#6
Open
jlaw9 wants to merge 4 commits intoadbharadwaj:masterfrom
Open
Modified the set_node_bubble_effect_property() function so it will on…#6jlaw9 wants to merge 4 commits intoadbharadwaj:masterfrom
jlaw9 wants to merge 4 commits intoadbharadwaj:masterfrom
Conversation
…ly set the 'text-outline-color' and 'text-outline-width'. Other attributes are already set by set_node_style()
…not be overwritten by default values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ly set the 'text-outline-color' and 'text-outline-width'. Other attributes are already set by set_node_style()
Forcing the border color to be the same as the text outline color isn't necessary and doesn't look very good.
Also fixed issue #4